refactor: replace docker pull push with skopeo #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdongo-aneo
force-pushed
the
jd/scopeo
branch
10 times, most recently
from
8fb229b to
b4d6cbe
Compare
jdongo-aneo
changed the title
jdongo-aneo
force-pushed
the
jd/scopeo
branch
2 times, most recently
from
629de02 to
d7bdb54
Compare
ngruelaneo
reviewed
Oct 25, 2024
There was a problem hiding this comment.
LGTM but I think you should explicit some information about this PR, for example using this PR template.
BTW, isn't this PR rather a refactor than a feat ?
jdongo-aneo
force-pushed
the
jd/scopeo
branch
2 times, most recently
from
ffcc063 to
4cc93f7
Compare
jdongo-aneo
changed the title
|
If you need to ensure an image is actually uploaded before being used, you should add a dependency on skopeo2_copy on the output |
jdongo-aneo
force-pushed
the
jd/scopeo
branch
from
83538d0 to
14365ec
Compare
jdongo-aneo
requested review from
lemaitre-aneo,
ngruelaneo and
tschneider-aneo
jdongo-aneo
force-pushed
the
jd/scopeo
branch
4 times, most recently
from
37530f6 to
5cbe4d6
Compare
lemaitre-aneo
changed the title
| @@ -3,7 +3,6 @@ variable "aws_profile" { | |||
| description = "AWS Profile used to login and push container images on ECR" | |||
| type = string | |||
| } | |||
|
|
|||
jdongo-aneo
force-pushed
the
jd/scopeo
branch
from
e16a4fd to
a33f2e3
Compare
Update container-registry/aws/ecr/main.tf Co-authored-by: lemaitre-aneo <[email protected]>
Update container-registry/aws/ecr/main.tf Co-authored-by: lemaitre-aneo <[email protected]>
jdongo-aneo
force-pushed
the
jd/scopeo
branch
3 times, most recently
from
e4a4fc1 to
b83d6e0
Compare
jdongo-aneo
force-pushed
the
jd/scopeo
branch
from
b83d6e0 to
b173395
Compare
lemaitre-aneo
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many calls for Docker pull and push to populate an internal ECR on AWS.
We suggest using Scope, a client that helps avoid this approach and simplifies the process by cloning images from a source to a target.